-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI cleanup of side panel #11262
UI cleanup of side panel #11262
Conversation
Signed-off-by: shivangrawat30 <[email protected]>
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! waiting for manual QA and we proceed to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ShivangRawat30, this is implemented correctly as specified!
@pcenov before we merge this, could you test this specific fix on IE11? It's possible that the use of |
Hi @rtibbles thank you for suggesting that, indeed in IE11 there is alaways a small white rectangle displayed after the name of the resource: |
I think this is an acceptable degradation in IE11 - not worth blocking for. |
Summary
Did the UI cleanup of resource duration in Content Renderer side panel
before
after
References
#11206
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)