Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cleanup of side panel #11262

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

ShivangRawat30
Copy link
Contributor

Summary

Did the UI cleanup of resource duration in Content Renderer side panel

before
266347589-b53df362-292a-46db-8f7c-21b39187c521

after
266353269-fdbe0345-ef47-477b-9af2-a9600cbb0939

References

#11206

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Signed-off-by: shivangrawat30 <[email protected]>
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Sep 18, 2023
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 18, 2023
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! waiting for manual QA and we proceed to merge.

@MisRob MisRob requested a review from pcenov September 19, 2023 12:26
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ShivangRawat30, this is implemented correctly as specified!

@rtibbles
Copy link
Member

@pcenov before we merge this, could you test this specific fix on IE11? It's possible that the use of min-height for the item might trigger a bug in flex-direction: column that happens in IE11.

@pcenov
Copy link
Member

pcenov commented Sep 25, 2023

Hi @rtibbles thank you for suggesting that, indeed in IE11 there is alaways a small white rectangle displayed after the name of the resource:

2023-09-25_12-23-39

@rtibbles
Copy link
Member

I think this is an acceptable degradation in IE11 - not worth blocking for.

@rtibbles rtibbles merged commit f5074bc into learningequality:release-v0.16.x Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants