Set insufficient storage DeviceStatus in ContentSyncHook.post_transfer #11255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
added this to the Kolibri 0.16 Release: Automatic Syncing Updates milestone
github-actions
bot
added
DEV: backend
Build Artifacts
|
bjester
requested changes
Sep 18, 2023
bjester
reviewed
Sep 18, 2023
| self._create_resources(self.admin_request.contentnode_id) | ||
| mock_hook.post_transfer = lambda *args: ContentSyncHook.post_transfer( | ||
| mock_hook, *args | ||
| ) |
There was a problem hiding this comment.
Looks like python2.7 tests are failing on this test. There shouldn't be any harm AFAIK in creating an instance of the ContentSyncHook so you could try to remove the mocking.
nucleogenesis
merged commit 2384ae1
into
learningequality:release-v0.16.x
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves the logic that calculates the total size of incomplete downloads from the request processing method into its own class.
That class then is imported to and used in ContentSyncHook.post_transfer to set the DeviceStatus to InsufficientStorage whenever there is not enough space available for the sync.
References
Fixes #10382
Reviewer guidance
Do we need to unset this when there is enough space or anything like that?
Thoughts on test coverage would be appreciated. I pulled in and used some existing test classes to do the data setup for me. @rtibbles and I discussed a test case for the StorageCalculator class but it is kind of covered by way of the many integration tests using the
_process_content_requestswhich repeatedly instantiate, use and rely on StorageCalculator.