Commit job state change before running update hooks #11170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without this, the state queried by
job_storage
will not match the updated state. This can cause a problem if a hook tries to restart a canceled job becausejob_storage
will still see the state asCANCELING
.Fixes: #11169
References
#11169
This fixes the case I was seeing. Before:
With this change, the job is queued and the server shuts down cleanly.
Reviewer guidance
See the description in #11169. Unfortunately, testing the job worker +
StorageHook
is not easy.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)