Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure c extension downloads are actually cached. #11137

Draft
wants to merge 6 commits into
base: release-v0.16.x
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 22, 2023

Summary

  • Fixes an oversight in the default cext_cache location to actually be within the repo folder
  • Makes directory creation already exists proof
  • Pins skip check action to specific version
  • Runs all checks always on push, ignoring the skip check, to ensure caches and historic builds get built properly
  • Runs a build on every push event to give up to date assets, and ensure build caches for pull requests

Reviewer guidance

This should cache the c extension downloads, so the best way to test is to rerun the WHL file job once it has competed.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Aug 22, 2023
@rtibbles rtibbles marked this pull request as draft August 25, 2023 21:10
@rtibbles
Copy link
Member Author

Converted this to draft for now, as this will need more work to actually make most of our caching have more of an impact on build performance.

@rtibbles rtibbles marked this pull request as ready for review September 30, 2023 19:39
@rtibbles rtibbles marked this pull request as draft October 13, 2023 18:17
@rtibbles
Copy link
Member Author

Turning this back to draft, as it seems that the caching improvements haven't improved build times even within this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment SIZE: medium SIZE: very large SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant