-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure c extension downloads are actually cached. #11137
Draft
rtibbles
wants to merge
6
commits into
learningequality:release-v0.16.x
Choose a base branch
from
rtibbles:faster_builds
base: release-v0.16.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: dev-ops
Continuous integration & deployment
DEV: backend
Python, databases, networking, filesystem...
SIZE: very small
labels
Aug 22, 2023
Build Artifacts
|
Converted this to draft for now, as this will need more work to actually make most of our caching have more of an impact on build performance. |
rtibbles
force-pushed
the
faster_builds
branch
from
September 30, 2023 00:42
20f30e6
to
8dc67c9
Compare
rtibbles
force-pushed
the
faster_builds
branch
from
September 30, 2023 00:44
8dc67c9
to
dfb3249
Compare
Turning this back to draft, as it seems that the caching improvements haven't improved build times even within this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DEV: backend
Python, databases, networking, filesystem...
DEV: dev-ops
Continuous integration & deployment
SIZE: medium
SIZE: very large
SIZE: very small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer guidance
This should cache the c extension downloads, so the best way to test is to rerun the WHL file job once it has competed.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)