Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource viewing wasted vertical spacing for smaller devices #11122

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Aug 18, 2023

Summary

This pr fixes the display of resources on android/smaller device screens that had too much spacing on top.

This pr also updates the import of defaultLanguage from kolibri-design-system/lib/utils/i18n to be imported from kolibri.utils.i18n instead within the file kolibri/plugins/learn/assets/src/views/AssessmentWrapper/index.vue instead to fix the error

Module not found: Error: Can't resolve 'kolibri-design-system/lib/utils/i18n' in '/Users/lianaharris/kolibri/kolibri/plugins/learn/assets/src/views/AssessmentWrapper'

received when running the dev server.

Before:
SmallScreenBefore

MediumScreenBefore

After:
SmallScreenAfter
MediumScreenAfter

References

Fixes #11074

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Aug 18, 2023
@LianaHarris360 LianaHarris360 marked this pull request as ready for review August 18, 2023 18:03
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LianaHarris360. Code changes make sense and manual testing also checks out!

@rtibbles rtibbles merged commit 2ef4d39 into learningequality:release-v0.16.x Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display of resources limited by apparently wasted vertical space
3 participants