Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui error resolved related to library #11090

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

GarvitSinghal47
Copy link
Contributor

#10931

Summary

Resolved the ui related issue of the home/library

Before :

uierror.webm

After :

uiresolved.webm

References

Reviewer guidance


Testing checklist

  • [x ] Contributor has fully tested the PR manually
  • [x ] If there are any front-end changes, before/after screenshots are included
  • [x ] Critical user journeys are covered by Gherkin stories
  • [x ] Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Aug 11, 2023
@MisRob MisRob self-requested a review August 16, 2023 10:11
@MisRob MisRob added the TODO: needs review Waiting for review label Aug 16, 2023
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GarvitSinghal47, code and preview is looking good to me. One thing before we can merge - could you run pre-commit (https://kolibri-dev.readthedocs.io/en/develop/getting_started.html?highlight=pre-commit#pre-commit-hooks) and push changes to resolve the linting check failure?

@MisRob
Copy link
Member

MisRob commented Aug 18, 2023

Thanks for the linting fixes @GarvitSinghal47 and merging the base branch. I don't think that the remaining failing check is related to this PR, so I think we will merge. Will follow-up on Monday.

@MisRob MisRob merged commit b356d93 into learningequality:release-v0.16.x Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants