Change the way we check for Android to use Python internals. #11072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
https://docs.python.org/3/library/sys.html#sys.getandroidapilevel
Reviewer guidance
I have tested this in an Android installer build, and a call to this API returns the Android API version against which it was compiled (so the minimum API version of 23 that we currently support). This suggests to me this is a robust check, as it is not dependent on anything at runtime.
This should also allow for easier experimentation with a non-P4A based implementation like chaquopy in the future.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)