Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way we check for Android to use Python internals. #11072

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 8, 2023

Summary

  • Switches from the Python for Android specific environment variable checking to checking if an Android only sys call is present

References

https://docs.python.org/3/library/sys.html#sys.getandroidapilevel

Reviewer guidance

I have tested this in an Android installer build, and a call to this API returns the Android API version against which it was compiled (so the minimum API version of 23 that we currently support). This suggests to me this is a robust check, as it is not dependent on anything at runtime.

This should also allow for easier experimentation with a non-P4A based implementation like chaquopy in the future.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 8, 2023
@rtibbles rtibbles requested a review from jamalex August 8, 2023 17:28
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Aug 8, 2023
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted through changes with richard - following that, lgtm!

@rtibbles rtibbles merged commit 9eceee4 into learningequality:release-v0.16.x Oct 12, 2023
@rtibbles rtibbles deleted the robustly_android branch October 12, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants