Update Exam model with V3 question_sources, update relevant JS utils #11025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
rtibbles
reviewed
Jul 30, 2023
rtibbles
reviewed
Aug 2, 2023
| description: '', | ||
| resource_pool: [], | ||
| questions: expectedSources.sort(), | ||
| learners_see_fixed_order: true, |
There was a problem hiding this comment.
Worth adding another test that ensures that this gets set to false if the exam is set to false?
There was a problem hiding this comment.
I don't see this additional test yet - if we add that, we should be good to merge.
18 tasks
rtibbles
approved these changes
Aug 11, 2023
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cohacked on w/ @thanksameeelian - adds commentary defining a new
question_sourcesarchitecture for the Exam model (V3) and updates the default value for thedata_model_versionproperty to3and includes the generated migration.Updates the
kolibri/core/assets/src/exams/utils.jsfile so that it remains backward compatible while also providing a function to be used in our new work using the V3 data structure.References
Closes #11002
Reviewer guidance
Nothing to manually test beside anything you can think of in Kolibri that might rely on getting V2 data structures so that we're sure of the backward compatibility measures working. @thanksameeelian and I looked at it and saw no issues.
As for the code - anything we've missed?
Testing checklist
PR process
Reviewer checklist
yarnandpip)