-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sidebar to use slots #10903
Refactor sidebar to use slots #10903
Conversation
this is not my actual sentiment, but reading your branch name made my brain go right to: stop-side-barring.mp4 |
Build Artifacts
|
i noticed that this introduced a bit of weirdness with the sidebar headers that i couldn't recreate on sidebar-headers.movi didn't encounter the same thing on even though it's a small difference, i think it takes away a little bit from the clarity of what those headers control. as an aside, i think it would be really nice if we could use CSS to truncate the search box placeholder text & add an ellipsis in this medium-size case where the text is not fully visible, as it cuts off a bit abruptly and as placeholder text isn't scrollable, so it feels a bit mysterious if you're only viewing it in a medium window size haha. but i know it's the same way on |
ah good catch, I thought I had reverted that (unintentional) change! yes this should definitely be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to prevent the sidebar issue interfering with QA.
Summary
Makes use of slots
Reduces the number of sticky calculations (no longer one for the tabs)
References
sticky-scroll.mp4
Reviewer guidance
This whole approach might be questionable because it is Friday evening
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)