-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes hidden search elements in search panel on scroll #10782
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good! I'll leave the final approval to @pcenov 's QA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akolson unfortunately this is not working in IE11 and mobile browsers such as Chrome and Firefox for Android as I am not able to see the 'Channel' dropdown in these browser when I scroll down. Here's a video for Internet Explorer 11:
2023-06-05_16-19-22.mp4
Note that you have to check this in an actual mobile phone device as if you are using Chrome's device emulator everything is looking just fine.
It turns out there is a bug associated with |
Hi @pcenov! Issue has been resolved on IE11 and, on chrome and firefox mobile browsers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @akolson - I confirm that this is fixed now in IE11 and mobile browsers.
Summary
This pr fixes hidden search elements in the search panel on scroll.
Before:
2023-06-02_11-24-46.mp4
After:
Show resources as last filter
Accessibility as last filter
Activities as last filter
References
Fixes #10775
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)