Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes hidden search elements in search panel on scroll #10782

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

akolson
Copy link
Member

@akolson akolson commented Jun 2, 2023

Summary

This pr fixes hidden search elements in the search panel on scroll.
Before:

2023-06-02_11-24-46.mp4

After:
Show resources as last filter
image
Accessibility as last filter
image
Activities as last filter
image

References

Fixes #10775

Reviewer guidance

  1. Import the QA channel and navigate to Learn > Library
  2. Observe the the filter section of the page while resizing the browser window to allow the search panel scroll.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the TODO: needs review Waiting for review label Jun 2, 2023
@akolson akolson requested a review from pcenov June 2, 2023 19:44
@github-actions github-actions bot added the APP: Learn Re: Learn App (content, quizzes, lessons, etc.) label Jun 2, 2023
@akolson akolson requested a review from nucleogenesis June 2, 2023 19:45
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good! I'll leave the final approval to @pcenov 's QA

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akolson unfortunately this is not working in IE11 and mobile browsers such as Chrome and Firefox for Android as I am not able to see the 'Channel' dropdown in these browser when I scroll down. Here's a video for Internet Explorer 11:

2023-06-05_16-19-22.mp4

Note that you have to check this in an actual mobile phone device as if you are using Chrome's device emulator everything is looking just fine.

@akolson
Copy link
Member Author

akolson commented Jun 5, 2023

It turns out there is a bug associated with overflow-y: scroll; that doesn't seem to take the bottom padding into consideration in some browsers. There is a workaround, 🤞 it works

@akolson
Copy link
Member Author

akolson commented Jun 6, 2023

Hi @pcenov! Issue has been resolved on IE11 and, on chrome and firefox mobile browsers;
IE11
image

Chrome Mac
image

Firefox Windows
image

Chrome Android
image

Firefox Android
image

@akolson akolson requested a review from pcenov June 6, 2023 16:55
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @akolson - I confirm that this is fixed now in IE11 and mobile browsers.

@akolson akolson merged commit 03af494 into learningequality:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library - Search bar - Cannot scroll all the way to the bottom
3 participants