enables sync button in sync modal

[akolson]

Summary

This pr enables the previously disabled Sync button in the facility syncing modal. It also corrects the display of the You must be connected to the internet message to only show when an internet connection is not available. The sync button is additionally disabled when there is no internet connection available. Finally, the tooltip has been removed.

Before:

After:

References

Fixes #10758

Reviewer guidance

• Navigate to Device > Facilities
• Select Sync all
• A syncing modal will open. Proceed to click the Sync button to start the syncing process
• You must be connected to the internet message is displayed when you set your connection to offline

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[akolson]

Tagging @jtamiace @tomiwaoLE to advise on

IMO, it probably doesn't make sense to to display the You must be connected to the internet message and disable the since we already have a global snackbar handling connectivity announcements that also prevents interaction with any interfaces underneath.

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0a14.dev0_git.14.g87ef53f5.pex
Windows Installer (EXE)	kolibri-0.16.0a14.dev0+git.14.g87ef53f5-unsigned.exe
Debian Package	kolibri_0.16.0a14.dev0+git.14.g87ef53f5-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0a14.dev0+git.14.g87ef53f5-0.3.0.dmg
Source Tarball	kolibri-0.16.0a14.dev0+git.14.g87ef53f5.tar.gz
WHL file	kolibri-0.16.0a14.dev0+git.14.g87ef53f5-py2.py3-none-any.whl

[bjester]

IMO, it probably doesn't make sense to to display the You must be connected to the internet message and disable the since we already have a global snackbar handling connectivity announcements that also prevents interaction with any interfaces underneath.

@akolson The client browser's connectivity isn't the same as Kolibri's connectivity. You of course could run Kolibri locally, be connected to Kolibri, but have no internet connection. That said, the string could/should be reworded along those lines for clarification.

[pcenov]

Hi @akolson, my understanding is that the message You must be connected to the internet. should be displayed not when the server is in a disconnected state but when the server is running while the person's device is with no internet access and therefore cannot sync with KDP.
See the following video:

2023-06-01_17-46-45.mp4

[nucleogenesis]

Code LGTM!

[akolson]

@bjester @jredrejo do we have an implementation that checks for the availability of KDP? There's a ToDo comment regarding this in the modal, just wondering if anything was ever implemented

[jredrejo]

@bjester @jredrejo do we have an implementation that checks for the availability of KDP? There's a ToDo comment regarding this in the modal, just wondering if anything was ever implemented

No, we don't, as far as i'm aware

[bjester]

do we have an implementation that checks for the availability of KDP?

We don't currently but with the new is_local field and when #10431 is completed, we can optimize this and use the existing network location API

[akolson]

Changes have been made following @pcenov 's feedback:

Screen.Recording.2023-06-02.at.00.51.10.mov

As a follow up to fully resolve this issue, there is need to check for;

1. Device's internet connectivity(implemented with this pr)
2. KDP's availability, a task that will follow once this comment has been addressed

[pcenov]

Excellent @akolson, this is implemented as specified now.