-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gives indication of user having permission to join the facility not showing the devices that don't have sign up enabled. #10703
Merged
nucleogenesis
merged 14 commits into
learningequality:develop
from
Wck-iipi:10313Solution
Jun 9, 2023
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2883171
Crude update for facility join problem.
Wck-iipi 8b54332
Used canLearnerSignUp instead of for loop.
Wck-iipi bf65758
Fixed boolean issues and uses NetworkLocationResource
Wck-iipi f730e5a
Disabling of KRadioButton, passes tests.
Wck-iipi 9e388b9
Removed Static Device's condition.
Wck-iipi 3e1e158
Added deviceFacilityCanSignUp and removed code.
Wck-iipi 42c1920
Merge branch 'learningequality:develop' into 10313Solution
Wck-iipi 7f216d5
Added LodDevicesWithSignUpFacitlity.
Wck-iipi 0f2e8f5
Merge branch 'learningequality:develop' into 10313Solution
Wck-iipi 56e8847
fixed Linting issues
Wck-iipi 2e4fd9d
Changed var name to lodsWithSignupFacility and reduced canLearnerSignUp
Wck-iipi 0ed7994
add needed mock to test suite
nucleogenesis 52cf5be
Merge branch 'develop' into 10313Solution
nucleogenesis eae1aa8
lint
nucleogenesis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wck-iipi
I'm not seeing anywhere that this ref's value is being read back. This could be used to conditionally put a
<KCircularLoader />
component (which is globally available, no need to import it from anywhere) in place of where either the data or the "no data" message should go?