Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to remote content browsing ui polish #10578

Conversation

akolson
Copy link
Member

@akolson akolson commented Apr 27, 2023

Summary

This pr fixes is a follow up to #10573 that;

  • Corrects the buggy routing implementation on refresh and click back
  • Delayed loading state on the Explore libraries page
  • Fixes the LibraryPage skipped tests

References

Follow up to #10573

Reviewer guidance

  • Explore a particular library. Clicking on the close button (X) at top left should take you back to the previous page. Also, refreshing the page and clicking the same should yield the same result
  • A loading state has been added to indicate load of the resources

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added the work-in-progress Not ready for review label Apr 27, 2023
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: medium labels Apr 27, 2023
@akolson akolson marked this pull request as ready for review April 27, 2023 13:47
@akolson akolson added the TODO: needs review Waiting for review label Apr 27, 2023
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to merge for the bug bash, and as I don't think there's anything blocking. The back button and refresh issues seem to be resolved (if I am understanding them correctly, at least).

As for the loading state, I think there is still something to be sorted out with the ui of the loading state, but I think there might be intersections with @nucleogenesis's work on the loading state cleanup, so I feel okay with merging and seeing once that is in what else needs to be sorted out, rather than duplicating or conflicting efforts.

@marcellamaki marcellamaki self-requested a review April 27, 2023 14:32
@marcellamaki marcellamaki merged commit a01a3dd into learningequality:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: medium TODO: needs review Waiting for review work-in-progress Not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants