Fix sync progress tracking overflow

[bjester]

Summary

This made sense when I first made the changes. Then looking back through, it doesn't seem that it actually does anything differently than before. It does seem to work though:

@rtibbles has now updated this. This seems to make more sense, as it seemed to be an issue with start_progress being called outside the context of the signal handlers, so the progress total was being rapidly set to 2, then 100, then 2 - and then never being reset.

References

Fixes #10077

Reviewer guidance

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b3.dev0_git.39.g69432d6e.pex
Windows Installer (EXE)	kolibri-0.16.0b3.dev0+git.39.g69432d6e-unsigned.exe
Debian Package	kolibri_0.16.0b3.dev0+git.39.g69432d6e-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b3.dev0+git.39.g69432d6e-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b3.dev0+git.39.g69432d6e-0.1.0-debug.apk
TAR file	kolibri-0.16.0b3.dev0+git.39.g69432d6e.tar.gz
WHL file	kolibri-0.16.0b3.dev0+git.39.g69432d6e-py2.py3-none-any.whl

[pcenov]

I can confirm that now the progress bar never runs over 100%. At the same time in all my tests it goes from 0 to 50% and then it finishes without showing any other percentage values, such as 75% for example:

2023-08-15_15-57-29.mp4

[rtibbles]

Hrm, not a roaring success then! I'll see if I can get 100% all the way!

[rtibbles]

This should now be correctly reaching 100%:

Screencast.from.08-22-2023.01.00.30.PM.webm

[pcenov]

@rtibbles I confirm, this is working correctly now, never going over 100% as well:

2023-08-23_14-23-57.mp4