Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote browsing of Studio #10450

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 11, 2023

Summary

  • Consolidates logic for checking Studio availability into the useDevices composable
  • Removes special casing for Studio and defers to using the baseurl GET parameter to fetch channels
  • Does a version check against Studio and all Kolibri devices to make sure they support remote content browsing
  • Adds navigation guards for the explore libraries page
  • Fixes some issues in the remote API logic that failed to properly raise errors
  • Fixes issue in the remote API logic that could cause Brotli encoded responses that the server cannot decode

References

Fixes #10280

Reviewer guidance

Run the dev server with this environment variable set:

KOLIBRI_CENTRAL_CONTENT_BASE_URL=https://unstable.studio.learningequality.org

Complete and proper functioning is dependent on this PR being merged: learningequality/studio#4018

This PR is now merged, and unstable should be updated automatically.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Apr 11, 2023
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Apr 11, 2023
@rtibbles rtibbles marked this pull request as ready for review April 12, 2023 17:26
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtibbles. These look like acceptable changes to me. Any other tweaks will be made with #10448

@rtibbles rtibbles merged commit df84c0d into learningequality:develop Apr 13, 2023
@rtibbles rtibbles deleted the studio_54 branch April 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: medium TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize Studio remote browsing integration
2 participants