Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move download string to core strings #10169

Merged

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Mar 1, 2023

Summary

Moves the existing "Download" string to core strings as we will soon need it in the content renderer (see #9856)

Reviewer guidance

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

as we will need it in the content renderer soon
@github-actions github-actions bot added the APP: Learn Re: Learn App (content, quizzes, lessons, etc.) label Mar 1, 2023
@MisRob MisRob added TODO: needs review Waiting for review TAG: user strings Application text that gets translated labels Mar 1, 2023
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does indeed seem to be the only string we need only for this specific place.

I do note that we need a 'Disconnected' string here and elsewhere, but let's merge this and make sure we have that too.

@rtibbles rtibbles merged commit fa43e2a into learningequality:develop Mar 1, 2023
@MisRob
Copy link
Member Author

MisRob commented Mar 2, 2023

I do note that we need a 'Disconnected' string here and elsewhere, but let's merge this and make sure we have that too.

@rtibbles this will be added by @jredrejo in the scope of #9859 (related Slack thread)

cc @marcellamaki @radinamatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TAG: user strings Application text that gets translated TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants