Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to visual styling of category selection UI #8787

Closed
indirectlylit opened this issue Nov 29, 2021 · 5 comments · Fixed by #8938
Closed

updates to visual styling of category selection UI #8787

indirectlylit opened this issue Nov 29, 2021 · 5 comments · Fixed by #8938
Labels
TODO: needs review Waiting for review

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Nov 29, 2021

Observed behavior

Following up from #8703 (comment) (cc @jtamiace @marcellamaki)

Notes on the current styling of category selection:

  1. Icons are small
  2. Side nav hover states have no transition, and modal clickable item hover states have a very slow transition
  3. Modal clickable items have a low-contrast hover styling and don't reflect current filter state

2021-11-29 13 39 32

Expected behavior

1. Icons should be bigger

image

2. Standard transitions on hover states

See our common hover timing functions:

https://github.com/learningequality/kolibri-design-system/blob/da045a48f9bb76a72b37565cb9b9f1386e48a83d/lib/styles/definitions.scss#L22-L30

and Material Design guidance on easing curves:

https://material.io/design/motion/speed.html#easing

3. Updates to modal clickable items

User-facing consequences

Category selection modals are a bit less polished than than they could be.

Context

0.15.0-beta2

@StarTrooper08
Copy link

Hey @indirectlylit , can I try to solve this issue?
I probably need some help at some point!!

sharifmaryam added a commit to sharifmaryam/kolibri that referenced this issue Dec 8, 2021
@sharifmaryam
Copy link
Contributor

hello, I thought I could solve the first issue of the icons being too small by making a change to the width and height in a index.vue file inside of the node_modules folder but I noticed that the node_modules folder is in the gitignore file so I was wondering if there was a different place in which these elements can be changed?

@indirectlylit
Copy link
Contributor Author

Hi @StarTrooper08 and @sharifmaryam – we've just added a new 'codebase contributions' section of our community forum!

https://community.learningequality.org/c/connections-contributions/kolibri-codebase-contributions/31

if you'd like some help understanding how the code base works, feel free to post your questions there, and thank you in advance for your contributions!

@rtibbles rtibbles added this to the 0.15.1 milestone Dec 16, 2021
@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 16, 2021
@rtibbles rtibbles mentioned this issue Dec 16, 2021
9 tasks
@marcellamaki marcellamaki modified the milestones: 0.15.1, 0.15.2 Feb 15, 2022
@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression and removed P0 - critical Priority: Release blocker or regression labels Apr 28, 2022
rtibbles pushed a commit to sharifmaryam/kolibri that referenced this issue May 18, 2022
@marcellamaki
Copy link
Member

Icons improved with #8938

@marcellamaki marcellamaki modified the milestones: Planned Patch 2: Content and a11y, Planned Patch 3: TBD May 19, 2022
@marcellamaki marcellamaki modified the milestones: Planned Patch 4: Coach usability improvements, Content Updates to support 0.16 Jun 22, 2022
@marcellamaki marcellamaki removed this from the Planned Patch 7 milestone Nov 22, 2022
@rtibbles
Copy link
Member

Remaining feedback was resolved with updates in #10986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants