-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to visual styling of category selection UI #8787
Comments
Hey @indirectlylit , can I try to solve this issue? |
hello, I thought I could solve the first issue of the icons being too small by making a change to the width and height in a index.vue file inside of the node_modules folder but I noticed that the node_modules folder is in the gitignore file so I was wondering if there was a different place in which these elements can be changed? |
Hi @StarTrooper08 and @sharifmaryam – we've just added a new 'codebase contributions' section of our community forum! https://community.learningequality.org/c/connections-contributions/kolibri-codebase-contributions/31 if you'd like some help understanding how the code base works, feel free to post your questions there, and thank you in advance for your contributions! |
Icons improved with #8938 |
Remaining feedback was resolved with updates in #10986 |
Observed behavior
Following up from #8703 (comment) (cc @jtamiace @marcellamaki)
Notes on the current styling of category selection:
Expected behavior
1. Icons should be bigger
2. Standard transitions on hover states
See our common hover timing functions:
https://github.com/learningequality/kolibri-design-system/blob/da045a48f9bb76a72b37565cb9b9f1386e48a83d/lib/styles/definitions.scss#L22-L30
and Material Design guidance on easing curves:
https://material.io/design/motion/speed.html#easing
3. Updates to modal clickable items
User-facing consequences
Category selection modals are a bit less polished than than they could be.
Context
0.15.0-beta2
The text was updated successfully, but these errors were encountered: