Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kolibri App - Navigation issue after Search on the Learn > Channels/Recommended pages #7769

Closed
metodimilevqa opened this issue Jan 27, 2021 · 3 comments · Fixed by #7777
Closed
Assignees
Labels
bug Behavior is wrong or broken P1 - important Priority: High impact on UX
Milestone

Comments

@metodimilevqa
Copy link

Observed behavior

Seems like there's a navigation issue in Kolibri App when the user makes a search from the Learn > Recommended > Most popular page or from the Learn > Channels page. For example, if I watch a video and then close it's page from the X icon and then I do a search, after I click the X icon to close the search results page I'm not brought back to Recommended > Most popular page but to the page of the video I initially watched. The same behavior is observed under Learn > Channels page.

popularSearchNavIssue2

Expected behavior

When the user closes the search results page the Learn > Channels/Recommended page is loaded but not the page with the last viewed item (video, pdf, epub, etc)

Steps to reproduce

Preconditions: Channels imported.

  1. Login to Kolibri app
  2. Click the hamburger menu
  3. Click Learn
  4. Click Recommended tab or stay on the Channels tab
  5. Browse down to a single item and click it
  6. Click the X icon in the upper left corner of the page.
  7. Do a Search in the upper right corner of the page
  8. Click the X icon in the upper left corner of the search results page
  9. See how you're back to the previously viewed single item but not to the main list in Channels/Recommended tab

Context

Kolibri 0.14.3
Windows 10 vm

@khangmach
Copy link
Contributor

I'm not sure why we redirect the user to the previous content page and I imagine this would look even more buggy and confusing to a user. Good catch

@jonboiser jonboiser added the bug Behavior is wrong or broken label Jan 28, 2021
@jonboiser jonboiser added this to the 0.14.7 milestone Jan 28, 2021
@jonboiser jonboiser added the P1 - important Priority: High impact on UX label Jan 28, 2021
@jonboiser jonboiser self-assigned this Jan 28, 2021
jonboiser added a commit to jonboiser/kolibri that referenced this issue Feb 1, 2021
jonboiser added a commit to jonboiser/kolibri that referenced this issue Feb 1, 2021
@jonboiser
Copy link
Contributor

@metodimilevqa I created a PR that should fix this issue here: #7777

Would you mind testing it?

@metodimilevqa
Copy link
Author

@jonboiser I confirm the issue is fixed with version 0.14.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken P1 - important Priority: High impact on UX
Projects
None yet
3 participants