Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'back' button and prop from core-modal #2663

Closed
indirectlylit opened this issue Nov 22, 2017 · 0 comments
Closed

remove 'back' button and prop from core-modal #2663

indirectlylit opened this issue Nov 22, 2017 · 0 comments
Assignees
@jonboiser
Labels
TAG: tech update / debt Change not visible to user

Comments

@indirectlylit
Copy link
Contributor

In #2610 we left-aligned the title for all modals. (https://github.com/learningequality/kolibri/pull/2610/files#diff-e923fca138f65eaa540bc7b969d702dfL222)

This is okay because enableBackBtn is not used anywhere. However we should remove enableBackBtn from the component entirely.
@indirectlylit indirectlylit added the TAG: tech update / debt Change not visible to user label Nov 22, 2017
@jonboiser jonboiser mentioned this issue Nov 27, 2017
Merged
12 tasks
jonboiser added a commit to jonboiser/kolibri that referenced this issue Nov 28, 2017
@jonboiser
Remove enableBackBtn prop from core-modal
bb7204e 
Fixes learningequality#2663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonboiser jonboiser

Labels
TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indirectlylit @jonboiser