Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start/stop/status leftovers: Add tests and more #1629

Closed
3 tasks
benjaoming opened this issue Jun 9, 2017 · 1 comment
Closed
3 tasks

Start/stop/status leftovers: Add tests and more #1629

benjaoming opened this issue Jun 9, 2017 · 1 comment
Labels
TAG: tech update / debt Change not visible to user TAG: unit tests Add or update tests

Comments

@benjaoming
Copy link
Contributor

Summary

After #1598 was merged, there were a few tasks left:

  • Adding real tests
  • Remove kolibri start/stop/status from tox.ini
  • Checking get_status before starting the server
@benjaoming benjaoming self-assigned this Jun 9, 2017
@benjaoming benjaoming mentioned this issue Jun 20, 2017
Closed
@christianmemije christianmemije added the TODO: needs gherkin update Add to our manual integration tests label Jun 27, 2017
benjaoming added a commit to benjaoming/kolibri that referenced this issue Jul 17, 2017
@benjaoming
Add test for KOLIBRI_LISTEN_PORT and some start/stop functionality le…
32e2429 
…arningequality#1629
@indirectlylit indirectlylit added the TAG: tech update / debt Change not visible to user label Oct 27, 2017
@indirectlylit indirectlylit added TAG: unit tests Add or update tests and removed TODO: needs gherkin update Add to our manual integration tests labels Mar 12, 2019
@rtibbles
Copy link
Member

All of these check mark items now appear to be implemented. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TAG: tech update / debt Change not visible to user TAG: unit tests Add or update tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benjaoming @rtibbles @indirectlylit @christianmemije