Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <SearchFiltersPanel> to accomodate differences in display between Learn and Coach, and within Coach, to manage quizzes (i.e. no Learning Activity types) vs. lesson resources #12521

Closed
Tracked by #12624 ...
marcellamaki opened this issue Aug 1, 2024 · 0 comments · Fixed by #12759
Assignees

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Aug 1, 2024

Prerequisite

#12676

Overview

The <SearchFiltersPanel/> is the component that exists within the Learn Library page, which enables searching and filtering making use of the metadata that could be added to a resource (activity type, category, etc.)

This component has already been moved into kolibri-common and now needs to be extended to manage both learn and coach cases. Within Coach, there is a slight variation when managing quizzes, which doesn't display the learning activity type options, vs. lesson resources, which does display the learning activity type selection.

The Figma spec for the Search Filters Panel is comprehensive, and that should be used as the source of truth and more closely followed than the general description here.

Important: The side panel modal behavior, and related components, are closely connected to the useSearch functionality. Refactoring how the component works in any significant way will cause problems. Please use an approach that focuses on presentational differences and conditional rendering rather than rebuilding the components or refactoring.

Acceptance criteria

Learn - all behavior and the UI remains the same, no regressions. This needs to be confirmed by the QA team before merging this work.

Coach

  1. The "Category Selection" modal used in the side panel should match the mobile view of the learn side panel.
  2. Focus should be trapped within the side panel modal, and functionality should match the side panel modal.
  3. The side panel options in coach should be accordion lists. Some remain multi-select, and some are radio buttons. This is distinct from learn
  4. Selection state management should also be implemented - with accordion headers being shown as "active" if a selection is made within the category, and inactive state if selections are not available. The "inactive" state implementation does exist in Learn and can be referenced.
  5. The refactored accordion implemented in Refactor accordion component #12693 should be used for the accordion, and any concerns about use cases/edge cases for behavior that the accordion doesn't currently cover should be raised for discussion in #coach-resource-discovery promptly
  6. Accordion headers should be H2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants