Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter to submit the Super Admin creation form in the Setup Wizard does not make form validation warnings visible #11465

Closed
rtibbles opened this issue Oct 26, 2023 · 4 comments
Assignees
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) bug Behavior is wrong or broken DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: a11y Affecting accessibility

Comments

@rtibbles
Copy link
Member

Observed behavior

When entering super admin details into the form for the setup wizard, if you type in passwords that do not match, and then on the second password box press 'enter' to submit, the submission will not happen because the passwords do not match, but no warning text is displayed to the user to explain why this is the case.

Expected behavior

Any attempt to submit should trigger form validation and display warning text to the user, in this case "passwords do not match"

User-facing consequences

Confusion, especially when passwords do not match due to a typo.

Steps to reproduce

  • Start the setup wizard from scratch
  • Use the 'on my own workflow'
  • Type in account details, using tab to move from one text box to the next
  • Type in differing passwords in each password box
  • Press enter to submit

Context

Kolibri 0.16.0-betas

Observed in Chrome, but probably not browser dependent.

@rtibbles rtibbles added bug Behavior is wrong or broken P2 - normal Priority: Nice to have TAG: a11y Affecting accessibility APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend help wanted Open source contributors welcome labels Oct 26, 2023
@rtibbles rtibbles added this to the 0.16 Future Patches triage milestone Oct 26, 2023
@a6ar55
Copy link
Contributor

a6ar55 commented Oct 28, 2023

I would like to work on this.

@MisRob
Copy link
Member

MisRob commented Oct 31, 2023

Hi @a6ar55, alright I'm assigning you.

@thesujai
Copy link
Contributor

thesujai commented Nov 3, 2023

There is a similar problem in login for home facility, for invalid username no warning is shown
Refer to the video below(only users with username thesujai and ram exists in my db):

Screencast.from.03-11-23.08.02.40.AM.IST.webm

jredrejo added a commit that referenced this issue Nov 24, 2023
Pressing enter to submit the Super Admin creation form in the Setup Wizard and show form validation error #11465
@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Closed by #11500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) bug Behavior is wrong or broken DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: a11y Affecting accessibility
Projects
None yet
Development

No branches or pull requests

5 participants