-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment of content on small mobile layout #1045
Comments
@indirectlylit I did not test in browserstack, but I can reproduce this issue in responsive layout view in both Chrome and Firefox. It seems the width of video player (and its upper containers) gets stuck at 840px even on smallest screen sizes: https://instantschools.learningequality.org/learn/#/recommended/1d8f6d84618153c18c695d85074952a7/content/82661ee52b345fbf9e82182e3f3ad3fa https://instantschools.learningequality.org/learn/#/recommended/1d8f6d84618153c18c695d85074952a7/content/82661ee52b345fbf9e82182e3f3ad3fa |
I get this when I load the online demo server (as you're using, @radinamatic), but not when I test locally with the latest version. It seems someone may have inadvertently fixed it along the way? I'm going to relaunch the demo server soon, after hearing back from VF about when a brief downtime is best to happen, but in the meantime, could we set you up for testing locally? |
Ok, demo server has been updated! Seems to work for me now. |
Literally magic, we don't know who fixed it. |
Oh, yeah -- I wasn't getting that on "iPhone 6", but I do see it on "iPhone 5" -- I think it's because there's no room for all the buttons in the bar, so it has an effective min-width; can we have it hide some of the controls below a certain width, @christianmemije? |
Forward and Rewind buttons would be my choices if we're hiding controls button at this width... |
Most exercises are now better, but some still have subtler issues, where they have components with bigger min-widths, e.g. https://instantschools.learningequality.org/learn/#/recommended/11d9de56da744f98877cc9fe710bb78d/content/9cefc3c618da41c79861df2a29ad8c9f May be no easy & general-purpose fix for this particular kind of issue. |
True, we may have to take them one-by-one at some point. |
thanks guys made a new issue for the one referenced above: #1074 |
Summary
Content container is aligned to the right edge of the view which makes impossible to interact with exercises and videos on smaller mobile layouts.
System information
Screenshots
Chrome
Firefox
The text was updated successfully, but these errors were encountered: