Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of content on small mobile layout #1045

Closed
radinamatic opened this issue Mar 9, 2017 · 12 comments
Closed

Alignment of content on small mobile layout #1045

radinamatic opened this issue Mar 9, 2017 · 12 comments
Assignees

Comments

@radinamatic
Copy link
Member

Summary

Content container is aligned to the right edge of the view which makes impossible to interact with exercises and videos on smaller mobile layouts.

System information

  • Version: 0.2.0alpha5.dev35
  • Operating system: iPhone 5S & Android 4.2.2
  • Browser: all (Safari, Chrome, Firefox)

Screenshots

Chrome
align3

Firefox
align4

@radinamatic
Copy link
Member Author

Reproducible on responsive view in Chrome dev tools, so you don't have to test on "real" mobile phone... 😛

instantschools learningequality org-learn- iphone 5 1

@radinamatic
Copy link
Member Author

Hint: if I deactivate the right: 0 for content-container it aligns left and at least is horizontally scrollable, which could be an interim solution:

count with small numbers - instant schools math - kolibri - google chrome_085

@radinamatic
Copy link
Member Author

@indirectlylit I did not test in browserstack, but I can reproduce this issue in responsive layout view in both Chrome and Firefox. It seems the width of video player (and its upper containers) gets stuck at 840px even on smallest screen sizes:

https://instantschools.learningequality.org/learn/#/recommended/1d8f6d84618153c18c695d85074952a7/content/82661ee52b345fbf9e82182e3f3ad3fa
overview of addition sums to 10 - ck-12 - kolibri - google chrome_091

overview of addition sums to 10 - ck-12 - kolibri - google chrome_092

https://instantschools.learningequality.org/learn/#/recommended/1d8f6d84618153c18c695d85074952a7/content/82661ee52b345fbf9e82182e3f3ad3fa
counting with small numbers - instant schools math - kolibri - mozilla firefox_093

@jamalex
Copy link
Member

jamalex commented Mar 15, 2017

I get this when I load the online demo server (as you're using, @radinamatic), but not when I test locally with the latest version. It seems someone may have inadvertently fixed it along the way? I'm going to relaunch the demo server soon, after hearing back from VF about when a brief downtime is best to happen, but in the meantime, could we set you up for testing locally?

@jamalex
Copy link
Member

jamalex commented Mar 15, 2017

Ok, demo server has been updated! Seems to work for me now.

@radinamatic
Copy link
Member Author

Ha, half an hour later, magic happens! 👍 🎉

getting to 10 by filling boxes - instant schools math - kolibri - google chrome_094

Player control bar is still too wide, not sure if we can do something about it... 🤔

@jamalex
Copy link
Member

jamalex commented Mar 15, 2017

Literally magic, we don't know who fixed it.

@jamalex
Copy link
Member

jamalex commented Mar 15, 2017

Oh, yeah -- I wasn't getting that on "iPhone 6", but I do see it on "iPhone 5" -- I think it's because there's no room for all the buttons in the bar, so it has an effective min-width; can we have it hide some of the controls below a certain width, @christianmemije?

@radinamatic
Copy link
Member Author

Forward and Rewind buttons would be my choices if we're hiding controls button at this width...

@jamalex
Copy link
Member

jamalex commented Mar 15, 2017

Most exercises are now better, but some still have subtler issues, where they have components with bigger min-widths, e.g. https://instantschools.learningequality.org/learn/#/recommended/11d9de56da744f98877cc9fe710bb78d/content/9cefc3c618da41c79861df2a29ad8c9f

May be no easy & general-purpose fix for this particular kind of issue.

@radinamatic
Copy link
Member Author

True, we may have to take them one-by-one at some point.

@indirectlylit
Copy link
Contributor

thanks guys

made a new issue for the one referenced above: #1074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants