Merge pull request #12910 from rtibbles/no_unused_all

Make no unused properties checking maximally strict
learningequality · Dec 13, 2024 · deecb99 · deecb99
2 parents d06c2b4 + a7a26e7
commit deecb99
Show file tree

Hide file tree

Showing 57 changed files with 64 additions and 731 deletions.
diff --git a/kolibri/plugins/bloompub_viewer/assets/src/views/BloomPubRendererIndex.vue b/kolibri/plugins/bloompub_viewer/assets/src/views/BloomPubRendererIndex.vue
@@ -118,15 +118,13 @@
         }
         return {};
       },
-      /* eslint-disable vue/no-unused-properties */
       /**
        * @public
        * Note: the default duration historically for HTML5 Apps has been 5 min
        */
       defaultDuration() {
         return 300;
       },
-      /* eslint-enable vue/no-unused-properties */
     },
     watch: {
       userData(newValue) {

diff --git a/kolibri/plugins/coach/assets/src/views/common/assignments/AssignmentCopyModal.vue b/kolibri/plugins/coach/assets/src/views/common/assignments/AssignmentCopyModal.vue
@@ -58,7 +58,9 @@
 
   const Stages = {
     SELECT_CLASSROOM: 'SELECT_CLASSROOM',
+    /* eslint-disable vue/no-unused-properties */
     SELECT_GROUPS: 'SELECT_GROUPS',
+    /* eslint-enable */
   };
 
   export default {

diff --git a/kolibri/plugins/coach/assets/src/views/learners/LearnerSummaryPage/LearnerHeader.vue b/kolibri/plugins/coach/assets/src/views/learners/LearnerSummaryPage/LearnerHeader.vue
@@ -113,7 +113,6 @@
 
   import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
   import commonCoach from '../../common';
-  import { useCoachTabs } from '../../../composables/useCoachTabs';
   import ReportsControls from '../../common/ReportsControls';
 
   export default {
@@ -122,13 +121,6 @@
       ReportsControls,
     },
     mixins: [commonCoach, commonCoreStrings],
-    setup() {
-      const { saveTabsClick, wereTabsClickedRecently } = useCoachTabs();
-      return {
-        saveTabsClick,
-        wereTabsClickedRecently,
-      };
-    },
     computed: {
       learner() {
         return this.learnerMap[this.$route.params.learnerId];

diff --git a/...ri/plugins/coach/assets/src/views/lessons/LessonResourceSelectionPage/ContentCardList.vue b/...ri/plugins/coach/assets/src/views/lessons/LessonResourceSelectionPage/ContentCardList.vue
@@ -88,7 +88,6 @@
 
 <script>
 
-  import { computed, toRefs } from 'vue';
   import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
   import { ViewMoreButtonStates } from '../../../constants/index';
   import LessonContentCard from './LessonContentCard';
@@ -99,14 +98,8 @@
       LessonContentCard,
     },
     mixins: [commonCoreStrings],
-    setup(props) {
-      const { selectAllChecked, selectAllIndeterminate } = toRefs(props);
-      // Code too long to display in template
-      const ariaChecked = computed(() => {
-        return selectAllChecked.value ? true : selectAllIndeterminate.value ? 'mixed' : false;
-      });
+    setup() {
       return {
-        ariaChecked,
         ViewMoreButtonStates,
       };
     },

diff --git a/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/CreateQuizSection.vue b/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/CreateQuizSection.vue
@@ -351,7 +351,6 @@
     mixins: [commonCoreStrings, commonCoach],
     setup() {
       const {
-        sectionLabel$,
         selectAllLabel$,
         addSectionLabel$,
         quizSectionsLabel$,
@@ -369,7 +368,6 @@
         questionsDeletedNotification$,
         expandAll$,
         collapseAll$,
-        questionDeletionConfirmation$,
       } = enhancedQuizManagementStrings;
 
       const { upLabel$, downLabel$ } = searchAndFilterStrings;
@@ -382,7 +380,6 @@
         deleteActiveSelectedQuestions,
         addSection,
         removeSection,
-        updateQuiz,
         selectAllQuestions,
         replacementQuestionPool,
         // Computed
@@ -391,7 +388,6 @@
         activeSectionIndex,
         activeSection,
         activeResourceMap,
-        activeResourcePool,
         activeQuestions,
         selectedActiveQuestions,
       } = injectQuizCreation();
@@ -403,7 +399,6 @@
 
       return {
         dragActive,
-        sectionLabel$,
         expandAll$,
         collapseAll$,
         selectAllLabel$,
@@ -415,7 +410,6 @@
         addQuizSectionQuestionsInstructions$,
         editSectionLabel$,
         deleteSectionLabel$,
-        questionDeletionConfirmation$,
         replaceAction$,
         questionsLabel$,
         numberOfReplacementsAvailable$,
@@ -431,7 +425,6 @@
         deleteActiveSelectedQuestions,
         addSection,
         removeSection,
-        updateQuiz,
         displaySectionTitle,
         displayQuestionTitle,
 
@@ -443,7 +436,6 @@
         activeSectionIndex,
         activeSection,
         activeResourceMap,
-        activeResourcePool,
         replacementQuestionPool,
         activeQuestions,
         selectedActiveQuestions,

diff --git a/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/QuestionListPreview.vue b/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/QuestionListPreview.vue
@@ -269,7 +269,6 @@
 
       return {
         content,
-        questions,
         currentQuestion,
         annotatedSections,
 

diff --git a/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/ReplaceQuestions.vue b/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/ReplaceQuestions.vue
@@ -151,7 +151,6 @@
   } from 'kolibri-common/strings/enhancedQuizManagementStrings';
   import { getCurrentInstance, computed, ref } from 'vue';
   import { get } from '@vueuse/core';
-  import isEqual from 'lodash/isEqual';
   import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
   import AccordionItem from 'kolibri-common/components/AccordionItem';
   import AccordionContainer from 'kolibri-common/components/AccordionContainer';
@@ -174,7 +173,6 @@
 
       const {
         replaceQuestions$,
-        deleteSectionLabel$,
         replaceAction$,
         selectAllLabel$,
         closeConfirmationMessage$,
@@ -185,7 +183,6 @@
         numberOfQuestionsReplaced$,
         noUndoWarning$,
         selectQuestionsToContinue$,
-        selectFewerQuestion$,
         collapseAll$,
         expandAll$,
       } = enhancedQuizManagementStrings;
@@ -198,19 +195,9 @@
         activeResourceMap,
         replacementQuestionPool,
         clearSelectedQuestions,
-        replaceSelectedQuestions,
-        toggleQuestionInSelection,
         handleReplacement,
-        allSections,
       } = injectQuizCreation();
 
-      const activeSectionTitle = computed(() => {
-        const activeSectionIndex = allSections.value.findIndex(section =>
-          isEqual(JSON.stringify(section), JSON.stringify(activeSection.value)),
-        );
-        return displaySectionTitle(activeSection.value, activeSectionIndex);
-      });
-
       const showCloseConfirmation = ref(false);
       const showReplacementConfirmation = ref(false);
       const replacements = ref([]);
@@ -273,8 +260,6 @@
         useAccordion(replacementQuestionPool);
 
       return {
-        createSnackbar,
-
         toggle,
         isExpanded,
         collapseAll,
@@ -285,24 +270,20 @@
         toggleInReplacements,
         activeSection,
         activeSectionIndex,
-        activeSectionTitle,
         selectAllReplacementQuestions,
         selectedActiveQuestions,
         replacementQuestionPool,
         selectAllIsIndeterminate,
         selectAllIsChecked,
-        replaceSelectedQuestions,
         activeResourceMap,
         showCloseConfirmation,
         showReplacementConfirmation,
         confirmReplacement,
 
         handleConfirmClose,
-        toggleQuestionInSelection,
         submitReplacement,
         replacements,
         replaceQuestions$,
-        deleteSectionLabel$,
         replaceAction$,
         selectAllLabel$,
         numberOfSelectedReplacements$,
@@ -312,7 +293,6 @@
         replaceQuestionsExplaination$,
         replaceQuestionsHeading$,
         selectQuestionsToContinue$,
-        selectFewerQuestion$,
         collapseAll$,
         expandAll$,
         displayQuestionTitle,

diff --git a/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/ResourceSelection.vue b/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/ResourceSelection.vue
@@ -248,7 +248,6 @@
         allResourceMap,
         updateSection,
         addQuestionsToSectionFromResources,
-        selectAllQuestions,
         allQuestionsInQuiz,
         activeQuestions,
         addSection,
@@ -268,7 +267,6 @@
       const selectPracticeQuiz = computed(() => props.selectPracticeQuiz);
 
       const {
-        sectionSettings$,
         numberOfSelectedBookmarks$,
         selectResourcesDescription$,
         questionsFromResources$,
@@ -722,8 +720,6 @@
         activeSectionIndex,
         activeQuestions,
         addSection,
-        allResourceMap,
-        allQuestionsInQuiz,
         selectAllChecked,
         selectAllIndeterminate,
         showSelectAll,
@@ -734,12 +730,9 @@
         handleConfirmClose,
         handleCancelClose,
         topic,
-        topicId,
         contentList,
-        resources,
         showCloseConfirmation,
         loading,
-        hasMore,
         loadingMore,
         fetchMoreResources,
         resetWorkingResourcePool,
@@ -748,13 +741,11 @@
         questionCount,
         maxQuestions,
         maxSectionQuestionOptions,
-        MAX_QUESTIONS_PER_QUIZ_SECTION,
         workingPoolUnusedQuestions,
         disableSave,
         cannotSelectSomeTopicWarning$,
         closeConfirmationMessage$,
         closeConfirmationTitle$,
-        sectionSettings$,
         numberOfQuestionsSelected$,
         tooManyQuestions$,
         maxNumberOfQuestions$,
@@ -764,14 +755,10 @@
         questionsFromResources$,
         windowIsSmall,
         bookmarks,
-        channels,
         viewMoreButtonState,
         updateSection,
         addQuestionsToSectionFromResources,
-        selectAllQuestions,
         workingResourcePool,
-        addToWorkingResourcePool,
-        removeFromWorkingResourcePool,
         showBookmarks,
         selectQuiz$,
         numberOfQuestionsToAdd$,

diff --git a/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/SectionEditor.vue b/kolibri/plugins/coach/assets/src/views/quizzes/CreateExamPage/SectionEditor.vue
@@ -134,11 +134,9 @@
   } from 'kolibri-common/strings/enhancedQuizManagementStrings';
   import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
   import { MAX_QUESTIONS_PER_QUIZ_SECTION } from 'kolibri/constants';
-  import useKResponsiveWindow from 'kolibri-design-system/lib/composables/useKResponsiveWindow';
   import useSnackbar from 'kolibri/composables/useSnackbar';
   import { PageNames } from '../../../constants/index';
   import { injectQuizCreation } from '../../../composables/useQuizCreation.js';
-  import useDrag from './useDrag.js';
 
   export default {
     name: 'SectionEditor',
@@ -153,12 +151,10 @@
         sectionSettings$,
         sectionTitle$,
         sectionTitleUniqueWarning$,
-        numberOfQuestionsLabel$,
         optionalDescriptionLabel$,
         numberOfQuestionsSelected$,
         deleteSectionLabel$,
         applySettings$,
-        sectionOrder$,
         questionOrder$,
         randomizedLabel$,
         randomizedOptionDescription$,
@@ -176,16 +172,13 @@
       const {
         activeSectionIndex,
         activeSection,
-        activeResourcePool,
         activeQuestions,
         allSections,
         updateSection,
         updateQuiz,
         removeSection,
       } = injectQuizCreation();
 
-      const { moveDownOne, moveUpOne } = useDrag();
-
       const showCloseConfirmation = ref(false);
 
       function handleCancelClose() {
@@ -271,8 +264,6 @@
         return activeSectionChanged.value || sectionOrderChanged.value;
       });
 
-      const { windowIsLarge, windowIsSmall } = useKResponsiveWindow();
-
       const resourceButtonLabel = computed(() => {
         if (activeQuestions.value.length === 0) {
           return addQuestionsLabel$();
@@ -304,49 +295,35 @@
         // useQuizCreation
         activeSectionIndex,
         activeSection,
-        activeResourcePool,
         activeQuestions,
         allSections,
         sectionOrderList,
         updateSection,
         updateQuiz,
         handleDeleteSection,
-        // dragging a11y
-        moveDownOne,
-        moveUpOne,
         // Form models
         learners_see_fixed_order,
         description,
         section_title,
         resourceButtonLabel,
         showResourceButton,
         maxQuestionsLabel,
-        // Responsiveness
-        windowIsLarge,
-        windowIsSmall,
         // i18n
         displaySectionTitle,
-        addQuestionsLabel$,
         sectionSettings$,
         sectionTitle$,
-        numberOfQuestionsLabel$,
         optionalDescriptionLabel$,
         numberOfQuestionsSelected$,
-        sectionDeletedNotification$,
         deleteSectionLabel$,
         applySettings$,
         closeConfirmationTitle$,
         closeConfirmationMessage$,
         deleteConfirmation$,
-        addMoreQuestionsLabel$,
-        sectionOrder$,
         questionOrder$,
         randomizedLabel$,
         randomizedOptionDescription$,
         fixedLabel$,
         fixedOptionDescription$,
-
-        createSnackbar,
       };
     },
     computed: {