Merge pull request #12700 from rtibbles/renderer_suffix

Move renderer suffix into core constants.
learningequality · Oct 7, 2024 · a760dee · a760dee
2 parents d9112f6 + 416cb49
commit a760dee
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/kolibri/core/assets/src/constants.js b/kolibri/core/assets/src/constants.js
@@ -200,3 +200,5 @@ export const Presets = Object.freeze({
 export const MAX_QUESTIONS_PER_QUIZ_SECTION = 25;
 
 export const DisconnectionErrorCodes = [0, 502, 504, 511];
+
+export const RENDERER_SUFFIX = '_renderer';
diff --git a/kolibri/core/assets/src/core-app/pluginMediator.js b/kolibri/core/assets/src/core-app/pluginMediator.js
@@ -1,6 +1,6 @@
 import Vue from 'vue';
 import scriptLoader from 'kolibri-common//utils/scriptLoader';
-import { RENDERER_SUFFIX } from '../views/ContentRenderer/constants';
+import { RENDERER_SUFFIX } from 'kolibri.coreVue.vuex.constants';
 import contentRendererMixin from '../views/ContentRenderer/mixin';
 import ContentRendererLoading from '../views/ContentRenderer/ContentRendererLoading';
 import ContentRendererError from '../views/ContentRenderer/ContentRendererError';

diff --git a/kolibri/core/assets/src/views/ContentRenderer/__tests__/DownloadButton.spec.js b/kolibri/core/assets/src/views/ContentRenderer/__tests__/DownloadButton.spec.js
@@ -1,8 +1,8 @@
 import Vue from 'vue';
 import { render, screen } from '@testing-library/vue';
 import useUser, { useUserMock } from 'kolibri.coreVue.composables.useUser';
+import { RENDERER_SUFFIX } from 'kolibri.coreVue.vuex.constants';
 import DownloadButton from '../DownloadButton.vue';
-import { RENDERER_SUFFIX } from '../constants';
 
 jest.mock('kolibri.coreVue.composables.useUser');
 

diff --git a/kolibri/core/assets/src/views/ContentRenderer/__tests__/utils.spec.js b/kolibri/core/assets/src/views/ContentRenderer/__tests__/utils.spec.js
@@ -1,6 +1,6 @@
 import Vue from 'vue';
+import { RENDERER_SUFFIX } from 'kolibri.coreVue.vuex.constants';
 import { canRenderContent, getRenderableFiles, getDefaultFile, getFilePreset } from '../utils';
-import { RENDERER_SUFFIX } from '../constants';
 
 // Add a component to the Vue instance that can be used to test the utility functions
 const addRegisterableComponents = (...presets) => {

diff --git a/kolibri/core/assets/src/views/ContentRenderer/constants.js b/kolibri/core/assets/src/views/ContentRenderer/constants.js
diff --git a/kolibri/core/assets/src/views/ContentRenderer/index.js b/kolibri/core/assets/src/views/ContentRenderer/index.js
@@ -1,4 +1,4 @@
-import { RENDERER_SUFFIX } from './constants';
+import { RENDERER_SUFFIX } from 'kolibri.coreVue.vuex.constants';
 import ContentRendererError from './ContentRendererError';
 import { canRenderContent, getRenderableFiles, getDefaultFile, getFilePreset } from './utils';
 

diff --git a/kolibri/core/assets/src/views/ContentRenderer/utils.js b/kolibri/core/assets/src/views/ContentRenderer/utils.js
@@ -1,5 +1,5 @@
 import Vue from 'vue';
-import { RENDERER_SUFFIX } from './constants';
+import { RENDERER_SUFFIX } from 'kolibri.coreVue.vuex.constants';
 
 export const canRenderContent = preset => Boolean(Vue.options.components[preset + RENDERER_SUFFIX]);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -200,3 +200,5 @@ export const Presets = Object.freeze({
		export const MAX_QUESTIONS_PER_QUIZ_SECTION = 25;

		export const DisconnectionErrorCodes = [0, 502, 504, 511];

		export const RENDERER_SUFFIX = '_renderer';