Imrproved naming for readability

learningequality · Sep 29, 2023 · 9188e6a · 9188e6a
1 parent 601fcd0
commit 9188e6a
Showing 1 changed file with 15 additions and 20 deletions.
diff --git a/kolibri/plugins/coach/assets/src/views/plan/LessonsRootPage/index.vue b/kolibri/plugins/coach/assets/src/views/plan/LessonsRootPage/index.vue
@@ -89,19 +89,7 @@
           </template>
         </CoreTable>
 
-        <p
-          v-if="!hasVisibleLessons &&
-            lessons.length"
-        >
-
-          {{ coreString('noResultsLabel') }}
-        </p>
-
-        <p
-          v-if="!hasNotVisibleLessons &&
-            lessons.length"
-        >
-
+        <p v-if="showNoResultsLabel">
           {{ coreString('noResultsLabel') }}
         </p>
 
@@ -250,14 +238,21 @@
         return { name: LessonsPageNames.LESSON_CREATION_ROOT };
       },
       hasVisibleLessons() {
-        return !(
-          !this.activeLessonCounts.true && this.filterSelection.value === 'filterLessonVisible'
-        );
+        return this.activeLessonCounts.true;
+      },
+      hasNonVisibleLessons() {
+        return this.activeLessonCounts.false;
       },
-      hasNotVisibleLessons() {
-        return !(
-          !this.activeLessonCounts.false && this.filterSelection.value === 'filterLessonNotVisible'
-        );
+      showNoResultsLabel() {
+        if (!this.lessons.length) {
+          return false;
+        } else if (this.filterSelection.value === 'filterLessonVisible') {
+          return !this.hasVisibleLessons;
+        } else if (this.filterSelection.value === 'filterLessonNotVisible') {
+          return !this.hasNonVisibleLessons;
+        } else {
+          return false;
+        }
       },
       calcTotalSizeOfVisibleLessons() {
         if (this.lessons && this.lessons.length) {