Skip to content

Commit

Permalink
Revert addition of loading state that waited for long timeout.
Browse files Browse the repository at this point in the history
Use loading prop instead.
  • Loading branch information
rtibbles committed Oct 16, 2023
1 parent 50e1295 commit 782aa60
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

<script>
import { computed, onBeforeMount, onBeforeUnmount, ref } from 'kolibri.lib.vueCompositionApi';
import { get, set } from '@vueuse/core';
import { computed, onBeforeMount, onBeforeUnmount } from 'kolibri.lib.vueCompositionApi';
import { get } from '@vueuse/core';
import KBreadcrumbs from 'kolibri-design-system/lib/KBreadcrumbs';
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
Expand Down Expand Up @@ -60,7 +60,6 @@
const className = computed(() => (get(classroom) ? get(classroom).name : ''));
const activeLessons = computed(() => getClassActiveLessons(get(classId)));
const activeQuizzes = computed(() => getClassActiveQuizzes(get(classId)));
const loading = ref(true);
let pollTimeoutId;
Expand All @@ -70,7 +69,6 @@
function pollForUpdates() {
fetchClass({ classId, force: true }).then(() => {
set(loading, false);
schedulePoll();
});
}
Expand All @@ -87,9 +85,14 @@
className,
activeLessons,
activeQuizzes,
loading,
};
},
props: {
loading: {
type: Boolean,
default: false,
},
},
computed: {
breadcrumbs() {
return [
Expand Down

0 comments on commit 782aa60

Please sign in to comment.