Merge pull request #9403 from rtibbles/perseus_message_shield

Move perseus specific logic into perseus renderer.
learningequality · May 4, 2022 · 48027e3 · 48027e3
2 parents 58ad79e + 7611d23
commit 48027e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/kolibri/plugins/learn/assets/src/views/ExamPage/index.vue b/kolibri/plugins/learn/assets/src/views/ExamPage/index.vue
@@ -301,11 +301,7 @@
     },
     watch: {
       attemptLogItemValue(newVal, oldVal) {
-        // HACK: manually dismiss the perseus renderer message when moving
-        // to a different item (fixes #3853)
         if (newVal !== oldVal) {
-          this.$refs.contentRenderer.$refs.contentView.dismissMessage &&
-            this.$refs.contentRenderer.$refs.contentView.dismissMessage();
           this.startTime = Date.now();
         }
       },

diff --git a/kolibri/plugins/perseus_viewer/assets/src/views/PerseusRendererIndex.vue b/kolibri/plugins/perseus_viewer/assets/src/views/PerseusRendererIndex.vue
@@ -275,6 +275,9 @@
         // Don't store blank state for another item.
         this.blankState = null;
 
+        // Clear any currently displayed messages when we render an item.
+        this.dismissMessage();
+
         // Create react component with current item data.
         // If the component already existed, this will perform an update.
         this.$set(