Merge pull request #12835 from m3tal10/fix-issue#8266

Added lazy loading attribute to thumbnail image tags
learningequality · Nov 19, 2024 · 4438ee2 · 4438ee2
2 parents 216bd26 + 9b7bb11
commit 4438ee2
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 0 deletions.
diff --git a/kolibri/plugins/device/assets/src/views/ManageContentPage/ChannelPanel/ChannelDetails.vue b/kolibri/plugins/device/assets/src/views/ManageContentPage/ChannelPanel/ChannelDetails.vue
@@ -10,6 +10,7 @@
         v-if="channel.thumbnail"
         class="thumbnail"
         :src="channel.thumbnail"
+        loading="lazy"
       >
       <KIcon
         v-else

diff --git a/kolibri/plugins/device/assets/src/views/SelectContentPage/ChannelContentsSummary.vue b/kolibri/plugins/device/assets/src/views/SelectContentPage/ChannelContentsSummary.vue
@@ -6,6 +6,7 @@
         v-if="channel.thumbnail"
         class="thumbnail"
         :src="channel.thumbnail"
+        loading="lazy"
       >
       <div class="channel-name">
         <KTooltip

diff --git a/kolibri/plugins/learn/assets/src/views/CardList.vue b/kolibri/plugins/learn/assets/src/views/CardList.vue
@@ -81,6 +81,7 @@
                     :alt="learnString('logo', { channelTitle: channelTitle })"
                     class="channel-logo"
                     :style="{ color: $themePalette.grey.v_800 }"
+                    loading="lazy"
                   >
                   <p
                     v-else

diff --git a/kolibri/plugins/learn/assets/src/views/HybridLearningContentCard/index.vue b/kolibri/plugins/learn/assets/src/views/HybridLearningContentCard/index.vue
@@ -34,6 +34,7 @@
           :src="channelThumbnail"
           :alt="learnString('logo', { channelTitle: channelTitle })"
           class="channel-logo"
+          loading="lazy"
         >
       </div>
       <CardThumbnail

diff --git a/kolibri/plugins/learn/assets/src/views/TopicsPage/TopicsMobileHeader.vue b/kolibri/plugins/learn/assets/src/views/TopicsPage/TopicsMobileHeader.vue
@@ -20,6 +20,7 @@
       <img
         :src="topic.thumbnail"
         class="channel-logo"
+        loading="lazy"
       >
     </KGridItem>
   </KGrid>

diff --git a/kolibri/plugins/learn/assets/src/views/thumbnails/ChannelThumbnail.vue b/kolibri/plugins/learn/assets/src/views/thumbnails/ChannelThumbnail.vue
@@ -10,6 +10,7 @@
       class="image"
       :src="thumbnailUrl"
       alt=""
+      loading="lazy"
     >
   </span>
 

diff --git a/kolibri/plugins/learn/assets/src/views/thumbnails/Thumbnail.vue b/kolibri/plugins/learn/assets/src/views/thumbnails/Thumbnail.vue
@@ -17,6 +17,7 @@
       class="image"
       :src="thumbnailUrl"
       alt=""
+      loading="lazy"
     >
     <slot name="labels"></slot>
   </span>
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,7 @@ @@
           class="image"
           :src="thumbnailUrl"
           alt=""
+          loading="lazy"
         >
       </span>
@@ Expand Down @@