Skip to content

Commit

Permalink
cannot call coreString in component definition, default placehodler t…
Browse files Browse the repository at this point in the history
…o null
  • Loading branch information
nucleogenesis committed Nov 12, 2024
1 parent 0c5c37b commit 432117b
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions packages/kolibri-common/components/SearchBox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
class="search-input"
:class="$computedClass(searchInputStyle)"
dir="auto"
:placeholder="placeholder"
:placeholder="placeholder || coreString('searchLabel')"
>
<div class="search-buttons-wrapper">
<KIconButton
Expand Down Expand Up @@ -62,7 +62,6 @@
<script>
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
import coreString from 'kolibri.utils.coreStrings';
export default {
name: 'SearchBox',
Expand All @@ -81,7 +80,7 @@
},
placeholder: {
type: String,
default: coreString.$tr('searchLabel'),
default: null,
},
value: {
type: String,
Expand Down

0 comments on commit 432117b

Please sign in to comment.