Transfer string from component to commonCoach

learningequality · Dec 21, 2023 · 11114d4 · 11114d4
1 parent e727dd0
commit 11114d4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/kolibri/plugins/coach/assets/src/views/common/commonCoachStrings.js b/kolibri/plugins/coach/assets/src/views/common/commonCoachStrings.js
@@ -603,6 +603,10 @@ const coachStrings = createTranslator('CommonCoachStrings', {
     context:
       'Indicates to the coach how many questions the learner answered correctly compared to the previous attempt',
   },
+  coachReportsLesson: {
+    message: 'Report lesson',
+    context: 'Labels the Reports > Lesson tab for screen reader users',
+  },
 });
 
 // Strings for the Missing Content modals, tooltips, alerts, etc.

diff --git a/kolibri/plugins/coach/assets/src/views/reports/ReportsLessonBase.vue b/kolibri/plugins/coach/assets/src/views/reports/ReportsLessonBase.vue
@@ -43,7 +43,7 @@
             <KTabsList
               ref="tabList"
               :tabsId="REPORTS_LESSON_TABS_ID"
-              :ariaLabel="$tr('coachReportsLesson')"
+              :ariaLabel="coachReportsLesson$()"
               :activeTabId="activeTabId"
               :tabs="tabs"
               @click="() => saveTabsClick(REPORTS_LESSON_TABS_ID)"
@@ -71,6 +71,7 @@
   import sortBy from 'lodash/sortBy';
   import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings';
   import commonCoach from '../common';
+  import { coachStrings } from '../common/commonCoachStrings';
   import CoachAppBarPage from '../CoachAppBarPage';
   import CSVExporter from '../../csv/exporter';
   import * as csvFields from '../../csv/fields';
@@ -92,10 +93,12 @@
     },
     mixins: [commonCoach, commonCoreStrings],
     setup() {
+      const {coachReportsLesson$} = coachStrings();
       const { saveTabsClick, wereTabsClickedRecently } = useCoachTabs();
       return {
         saveTabsClick,
         wereTabsClickedRecently,
+        coachReportsLesson$,
       };
     },
     props: {
@@ -271,12 +274,6 @@
         }
       },
     },
-    $trs: {
-      coachReportsLesson: {
-        message: 'Report lesson',
-        context: 'Labels the Reports > Lesson tab for screen reader users',
-      },
-    },
   };
 
 </script>