Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-QA Fixes: Admin panel, #209

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Post-QA Fixes: Admin panel, #209

merged 8 commits into from
Dec 17, 2024

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Dec 10, 2024 •
edited
Loading

Summary

  • Conditionalizes various prod-only settings such that they're True unless DEBUG=True so I can avoid issues in development
  • Adds the Django Admin to the routes & installed apps so that we can access /admin
  • Override Django 3.2 default for SECURE_FRAME_DENY & X_FRAME_OPTIONS to permit iframe rendering of About & FAQ pages contents
  • Update's module version to match compatible Kolibri version
  • Use appBarText theme token to fix hover color issues

TODO

References

Fixes #207
Fixes #205

Reviewer guidance

Code review - then we'll get it deployed to staging.

@nucleogenesis nucleogenesis marked this pull request as ready for review December 10, 2024 23:24
nucleogenesis
nucleogenesis commented Dec 13, 2024
View reviewed changes
kolibri_instant_schools_plugin/kolibri_plugin.py Outdated
Comment on lines 103 to 104
"appBar": "#333333",
"appBarText": "#ffffff",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can remove this

@nucleogenesis nucleogenesis merged commit 343157c into learningequality:develop Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 'About' page is not rendered correctly Main navigation - The hover effect is too dark
2 participants
@nucleogenesis @rtibbles