Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logos for windows installer. #224

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update logos for windows installer. #224

merged 2 commits into from
Apr 30, 2024

Conversation

rtibbles
Copy link
Member

Fixes #220

To test this, confirm that the new Kolibri logo appears during the installation process and in the system tray icon and that it looks good!

Note that the PR build here will not include the rebranded Kolibri, so anything inside Kolibri will not have changed.

@pcenov
Copy link
Member

pcenov commented Apr 29, 2024

Hi @rtibbles, I tested the installer in Windows 11 and Windows 7 and I can confirm that the new logo appears during the installation process and in the system tray icon:

Installation:

2024-04-29_10-30-06

2024-04-29_10-30-30

System tray:

2024-04-29_10-39-52

Windows 11's Start Menu:

2024-04-29_10-58-50

I also noticed the following issues which should be addressed either here or as a follow-up:

Windows 7: The new logo is not displayed in the Start Menu:

2024-04-29_11-33-27

Windows 11: The new logo is not displayed in the pop-up notification:

2024-04-29_10-35-49

All Windows versions: The new logo is not displayed in Control Panel > Programs and Features:

2024-04-29_10-45-06

All Windows versions: The new logo is not displayed for the Desktop shortcut:

2024-04-29_11-32-24

@radinamatic
Copy link
Member

Thank you @pcenov for testing on Windows 7 and 11 too. 👍🏽

One thing that is different from my own testing on Windows 10 with the first asset from this PR, is that on my VM the desktop shortcut icon was displaying correctly. Regression from the latest commit when the system tray icon was improved?

2024-04-29_11-35-37

@radinamatic
Copy link
Member

Confirming that with the newest asset, the system tray icon looks somewhat bigger:

old asset new asset
2024-04-27_00-12-52-system-tray1 2024-04-29_11-56-04-system-tray2

And with the fresh install of this latest asset I can still see the desktop shortcut and the start/stop notifications with the new logo icon, on Windows 10 at least:

2024-04-29_12-04-29

I will try on the Windows 11 too, but @pcenov could you confirm that the installations are on a fresh VM snapshots that never had Kolibri installed before? Just trying to exclude some weird cache issues... Thank you!

@pcenov
Copy link
Member

pcenov commented Apr 29, 2024

Hi @radinamatic - yes, it turned out to be a cache related issue - I have retested on Win 7, 10 and 11 and the logo is displayed correctly after a clean install or after restarting the device.
The only issue that is still valid is the one about the missing logo in Control Panel > Programs and Features but that's a pre-existing issue.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA confirms to this is good to go

@rtibbles rtibbles merged commit 13facbd into main Apr 30, 2024
3 checks passed
@rtibbles rtibbles deleted the some_logo branch April 30, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kolibri icon
4 participants