New foundation page for errors and other minor changes #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Inline error messages | ||
| </h3> | ||
| <p> | ||
| Place inline error messages in close proximity to where the error occurred. This can be an icon only, or icon and text. When paired with text, use <code>KLabeledIcon</code> |
There was a problem hiding this comment.
This won't work until we add a docs page for it, but when we do we'll be able to use DocsInternalLink with code attribute:
<DocsInternalLink code href="/klabeledicon">KLabeledIcon</DocsInternalLink>
Co-authored-by: Devon Rueckner <[email protected]>
indirectlylit
force-pushed
the
errors
branch
from
0804d5f to
f6a1715
Compare
indirectlylit
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main submission is a new foundation page for error patterns.
Reference: https://docs.google.com/document/d/1Y-lCHIolecpf3XgCnRlGRs08cVrv6hc7dSMAwxr_HI8/edit
Other changes
DocsDoNotcontainer across all pagesNew errors page
Updated styling for principles