Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend KCard class names with k #851

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Prepend KCard class names with k #851

merged 1 commit into from
Dec 9, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Dec 5, 2024 •
edited
Loading

Description

Prepends all internal KCard class names with k to prevent from aggressive overrides from global Vuetify styles in Studio, for example when KCard's .title styles were changed unexpectedly by the Vuetify's .title styles, causing text being cut off and incorrectly styled overall.

Before After
Screenshot from 2024-12-05 16-29-16 Screenshot from 2024-12-05 16-28-00

Issue addressed

Reported by @akolson while working on learningequality/studio#4803

Changelog

  • Description: Prepends all internal KCard class names with k
  • Products impact: bugfix
  • Addresses: Prevent from aggressive overrides from global Vuetify styles in Studio, for example when KCard's .title styles were changed unexpectedly by the Vuetify's .title styles, causing text being cut off and incorrectly styled overall. Reported in Implement recommendations display studio#4803.
  • Components: KCard
  • Breaking: no
  • Impacts a11y: no
  • Guidance: -

Steps to test

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

@MisRob MisRob requested a review from akolson December 5, 2024 15:41
@MisRob MisRob added the TODO: needs review Waiting for review label Dec 5, 2024
akolson
akolson approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MisRob

@MisRob
Prepend KCard class names with 'k'
35ea670 
to prevent from aggressive overrides
from global Vuetify styles in Studio,
for example when KCard's '.title' styles
were changed unexpectedly by the
Vuetify '.title' styles.
@MisRob MisRob mentioned this pull request Dec 9, 2024
Open
akolson
akolson approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks @MisRob.

@akolson akolson merged commit 903e831 into learningequality:develop Dec 9, 2024
10 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@github-actions
Update CHANGELOG.md for PR #851
2772327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolson akolson akolson approved these changes

Assignees
No one assigned
Labels
TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MisRob @akolson