Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added radiogroup role to KRadioButtonGroup #846

Merged

Conversation

iamshobhraj
Copy link
Contributor

@iamshobhraj iamshobhraj commented Nov 27, 2024

Issue addressed

Addresses #828

Changelog

  • Description: Added radiogroup role to the KRadioButtonGroup component as described in https://www.w3.org/WAI/ARIA/apg/patterns/radio/
  • Products impact: none
  • Addresses: addresses Add radiogroup role to the KRadioButtonGroup #828
  • Components: KRadioButtonGroup component.
  • Breaking: No
  • Impacts a11y: yes
  • Guidance: radiogroup role offers a better UX to screen reader users by providing context that they are navigating through (and selecting from) a group of related set of options, and how many they have available.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@MisRob
Copy link
Member

MisRob commented Dec 2, 2024

Thank you @iamshobhraj! I will invite my colleagues for review.

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iamshobhraj for adding the proper radiogroup role to KRadioButtonGroup, the keyboard navigation still works as intended so this PR is ready to be merged!

@LianaHarris360 LianaHarris360 merged commit 321f4ec into learningequality:develop Dec 3, 2024
9 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants