Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added update-spreadsheet action #835

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

GarvitSinghal47
Copy link
Contributor

@GarvitSinghal47 GarvitSinghal47 commented Nov 20, 2024

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

Changelog

  • Description: Enables the action that updates the contributions spreadsheet
  • Products impact: no
  • Addresses: -
  • Components: -
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@MisRob MisRob self-assigned this Nov 20, 2024
@MisRob MisRob requested review from rtibbles and MisRob November 20, 2024 06:21
@MisRob MisRob added the TODO: needs review Waiting for review label Nov 20, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me here and all secrets are ready on this repo. Thank you @GarvitSinghal47. I will let @rtibbles to make final confirmation before I merge.

@MisRob MisRob merged commit 8d4b7b7 into learningequality:develop Dec 4, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants