Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal implementation of KToolbar. #831

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

rtibbles
Copy link
Member

Description

  • Moves UiToolbar from the keen dir and makes minimal edits to turn it into KToolbar
  • Also integrates the styling that is always applied in Kolibri itself in the wrapped kolibri-common/components/UiToolbar component

Changelog

  • Description: Creates the initial KToolbar component as a direct port of UiToolbar
  • Products impact: new API, removed API - adds KToolbar, removes UiToolbar from the keen dir
  • Addresses: N/A
  • Components: UiToolbar, KToolbar
  • Breaking: yes
  • Impacts a11y: no
  • Guidance: Creates initial KToolbar component as a port of UiToolbar. Further changes and iterations to API expected.

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@marcellamaki marcellamaki merged commit 012fbf9 into learningequality:develop Nov 26, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants