-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for kselect #821
Conversation
Hi @AlexVelezLl, please help in reviewing |
Hi @yeshwanth235, thanks! @AllanOXDi and @ozer550 would you please review, and @AlexVelezLl perhaps you could then give it a final look and merge? |
Hi @yeshwanth235, just chiming in to mention @AllanOXDi has review in progress (cc @AlexVelezLl). We will follow-up with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yeshwanth235, great work on this! I’ve added a few comments suggesting some improvements for your consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @yeshwanth235
@AlexVelezLl is there anything still missing on this PR - if not we can merge it |
Hi @AllanOXDi, PR approve was revoked by mistake 😅. Please help in approving again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yeshwanth235! Just some suggestions to make the wording consistent with the docs of other components 🤗, and some clarifications about some props that werent well described. After this, we can merge this PR :). Thank you!
lib/KSelect/index.vue
Outdated
@@ -43,6 +43,7 @@ | |||
:class="labelClasses" | |||
:style="activeColorStyle" | |||
> | |||
<!-- @slot Displays the label --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- @slot Displays the label --> | |
<!-- @slot Optional slot as alternative to `label` prop --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the delay in addressing the PR comments. The comments have now been addressed. Please review at your earliest convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries @yeshwanth235. Thank you!! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yeshwanth235!! Looks good to me! 🚀🚀
Description
Issue addressed
#664 (comment)
Addresses #PR# HERE
Before/after screenshots
Before
After
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Vue Docgen API generates JSDoc documentation for components.
Reviewer guidance
Comments