-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added arialabelled Prop for kSwitch #808
added arialabelled Prop for kSwitch #808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sahil-Sinha-11 thanks for working on this! This looks like the right changes, I just suggested a little improvement in the jsdoc of the new prop.
Also, when you create a PR, in the "issue addressed" section in the PR description, you should add the issue number next to the Addresses #...
, so you should have something like this: Addresses #806
Hey @AlexVelezLl , I changed the Issue addressed in the change log and the comment as you advised. |
Thank you @Sahil-Sinha-11! This looks good! Now it seems that we have some linting issues 😅. Could you please fix them by running |
Hey @AlexVelezLl I fixed it. Sorry for the trouble. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, thank you @Sahil-Sinha-11! 🎉 Good job! Merging!
Description
Issue addressed
Addresses #806
Before/after screenshots
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments