Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added arialabelled Prop for kSwitch #808

Merged

Conversation

Sahil-Sinha-11
Copy link
Contributor

@Sahil-Sinha-11 Sahil-Sinha-11 commented Oct 25, 2024

Description

Issue addressed

Addresses #806

Before/after screenshots

Image
Image

Changelog

  • Description: Adds ariaLabelledBy prop to KSwitch.
  • Products impact: Improved accessibility.
  • Addresses: -[KSwitch]: Add ariaLabelledBy prop [KSwitch]: Add ariaLabelledBy prop #806
  • Components: KSwitch
  • Breaking: -
  • Impacts a11y: -
  • Guidance:-

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@AlexVelezLl AlexVelezLl self-requested a review October 25, 2024 19:43
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sahil-Sinha-11 thanks for working on this! This looks like the right changes, I just suggested a little improvement in the jsdoc of the new prop.

Also, when you create a PR, in the "issue addressed" section in the PR description, you should add the issue number next to the Addresses #..., so you should have something like this: Addresses #806

lib/KSwitch.vue Outdated Show resolved Hide resolved
@Sahil-Sinha-11
Copy link
Contributor Author

Hey @AlexVelezLl , I changed the Issue addressed in the change log and the comment as you advised.

@AlexVelezLl
Copy link
Member

Thank you @Sahil-Sinha-11! This looks good! Now it seems that we have some linting issues 😅. Could you please fix them by running yarn run lint-fix and pushing these changes, please? 👐

@Sahil-Sinha-11
Copy link
Contributor Author

Hey @AlexVelezLl I fixed it. Sorry for the trouble. 😅

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo, thank you @Sahil-Sinha-11! 🎉 Good job! Merging!

@AlexVelezLl AlexVelezLl merged commit ce970a4 into learningequality:develop Oct 28, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants