Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unsorted option for KTable #803

Merged

Conversation

Sahil-Sinha-11
Copy link
Contributor

@Sahil-Sinha-11 Sahil-Sinha-11 commented Oct 19, 2024

Description

Added unsorted option for KTable

Issue addressed

797

After video

Screen.Recording.2024-10-15.at.12.25.45.AM.mov

Changelog

  • Description: Adds the option to get back to the unsorted state after sorting a KTable column, making it flow to be unsorted->ascending -> descending -> unsorted.
  • Products impact: updated API
  • Addresses: [KTable]: Update Sorting Flow to Include "Unsorted" State #797
  • Components: KTable
  • Breaking: no
  • Impacts : Adds flexibility in how users can interact with the table, especially when sorting is not desired or needs to be reset.

Steps to test

  1. Step 1
  2. Step 2
  3. ...

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@BabyElias
Copy link
Contributor

@Sahil-Sinha-11 Can you please update the Changelog in description with all the fields that were originally in the template?
You can see the Changelog here for reference. Thanks :)

@Sahil-Sinha-11
Copy link
Contributor Author

@BabyElias I edited the Changelog . Could you please review it. Thanks.

@AlexVelezLl AlexVelezLl self-requested a review October 23, 2024 13:34
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me. Thank you @Sahil-Sinha-11, good job!!

@AlexVelezLl AlexVelezLl merged commit a58f224 into learningequality:develop Oct 23, 2024
10 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants