Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spaces to the latest designs #709

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Jul 31, 2024

Description

This PR refines the spacing between the card's content and its border to adhere to the most recent design standards.

Issue addressed

#704

Changelog

[#709]

Steps to test

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@AllanOXDi AllanOXDi changed the title adds spacing 24px to the top, right,left and bottom Update spaces to the latest designs Jul 31, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! The test failure is not related to this work.

@AllanOXDi AllanOXDi merged commit 5755ea5 into learningequality:develop Aug 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants