add custom validation #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
reviewed
Jul 31, 2024
| LARGE: 'large' | ||
| }; | ||
|
|
||
| function cardValidator(allowedValues, propName) { |
MisRob
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @AllanOXDi. I left one note that would be nice to have before merge, and also lint and changelog checks will need to pass. After that, feel free to merge.
MisRob
reviewed
Jul 31, 2024
lib/KCard/index.vue
Outdated
| }, | ||
| thumbnailDisplay: { | ||
| type: String, | ||
| default: Thumbnail_Displays.NONE, |
There was a problem hiding this comment.
It'd be ideal if we could use constants as default values, but unfortunately there's limitation regarding our documentation generation that can't pick it up:
Would you please revert to default: 'none' on this line? Same applies to default: Layouts .HORIZONTAL,
This will ensure that consumers will understand what values, previously mentioned in the prop description, are used as defaults
MisRob
reviewed
Aug 1, 2024
MisRob
reviewed
Aug 1, 2024
| @@ -4,15 +4,17 @@ Changelog is rather internal in nature. See release notes for the public overvie | |||
|
|
|||
| ## Upcoming version 5.x.x (`develop` branch) | |||
|
|
|||
| [#709] | |||
There was a problem hiding this comment.
Seems like a merge conflict? I think this change should stay here.
AllanOXDi
force-pushed
the
Custom-validations
branch
from
f4f45ab to
3f3f9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Addresses #PR# HERE
Before/after screenshots
Changelog
[add custom validation #707]
KCardcomponentKCard[add custom validation #707]: add custom validation #707
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
After review
CHANGELOG.mdComments