Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom checks from the server script to use concurrently #677

Conversation

KshitijThareja
Copy link
Contributor

Description

This PR replace the use of custom script to handle server startup and termination with concurrently.

Issue addressed

#676

Changelog

  • [#PR no]
    • Description: Replaces custom configuration in runVisualTests.js for server startup and termination by concurrently. Also migrate other essential checks to visual.index.js thereby eliminating the need for a custom script.
    • Products impact: -
    • Addresses: Visual Testing: Replace the current run script to use concurrently #676
    • Components: -
    • Breaking: -
    • Impacts a11y: -
    • Guidance: -

[#PR no]: PR link

Steps to test

  1. Add the PERCY_TOKEN env variable before running tests.
  2. Run the tests using yarn test:visual to see the new changes in action.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

package.json Outdated
@@ -59,6 +66,8 @@
"npm-run-all": "^4.1.5",
"nuxt": "2.15.8",
"prismjs": "^1.27.0",
"ps-tree": "^1.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you can remove this now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah. Will make the changes 👍

@KshitijThareja
Copy link
Contributor Author

Hi @bjester :)
Can this PR be merged now if there are no further changes required?

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 3ef3ee1 into learningequality:gsoc/visual-testing Jul 16, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants