Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #644 - 'Changelog' text changed to 'Release Notes' #653

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

musser004
Copy link
Contributor

@musser004 musser004 commented Jun 8, 2024

Description

BranchLink.vue modified with 'Release Notes' instead of existing 'Changelog' text and href changed to 'https://github.com/learningequality/kolibri-design-system/releases' in order to satisfy Issue #644

Issue addressed

Issue #644

Before/after screenshots

Before:

image

After:

image

Changelog

Steps to test

  1. Go to documentation home page
  2. Click the "Release notes" link and confirm that it's going to the correct location

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

…es' and link location changed

BranchLink.vue modified with 'Release Notes' instead of existing 'Changelog' text and href changed to 'https://github.com/learningequality/kolibri-design-system/releases' in order to satisfy Issue learningequality#644
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good! Thanks @musser004

@AllanOXDi
Copy link
Member

Could you update Changelog.md to make sure that all the checks pass

@musser004
Copy link
Contributor Author

Hi Allen,

Thanks for reviewing. Does that changelog look correct now? First time contributing here, so I can definitely adjust that further if needed

@AllanOXDi
Copy link
Member

Yes, everything looks good with the changelog. @musser004 . Thanks for contributing!

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @musser004! 🎉 LGTM!

@AlexVelezLl AlexVelezLl merged commit 9f5f503 into learningequality:release-v4 Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants