Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates points icon #630

Merged

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented May 7, 2024

Description

Updates the icon set to include the updated points icon, aligned with the new brand

Before/after screenshots

New points icon (and "inactive" points icon has been removed)
Screenshot 2024-05-07 at 7 58 53 AM

Changelog

  • [Updates points icon #630]
    • Description: Updates the svg for the pointsLeafActive, and removes the pointsLeafInactive (which is not used anywhere in Kolibri,
    • Products impact: Relevant for Kolibri
    • Addresses: Figma specs for new theme
    • Breaking: Will this change break something in a consumer? No
    • Impacts a11y: No
    • Guidance: This should be a seamless update with no changes required.

[#PR no]: PR link

Steps to test

  1. Pull PR locally
  2. Run yarn run dev to run local server
  3. Navigate to "icons" library at http://localhost:4000/icons

(optional) Implementation notes

Does this introduce any tech-debt items?

Not in and of itself, but there is some corresponding cleanup in Kolibri to remove the references to pointsLeafInactive, although it was not actually being used anywhere, already.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

After review

  • The changelog item has been pasted to the CHANGELOG.md

@marcellamaki marcellamaki requested review from MisRob and AlexVelezLl May 7, 2024 12:22
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcellamaki! Everything looks good, but in the svg icon, at the end of the <path> tag there is a fill="black" property that should be removed.

<svg ... >
<path fill-rule="evenodd" ... fill="black" <- this property />
</svg>

With this property there we cant add custom colors to the icon. After doing this we should be able to see the pointsActive icon with custom colors

@marcellamaki marcellamaki force-pushed the update-points-icon branch from 657a60b to e45b7c3 Compare May 7, 2024 17:48
@marcellamaki
Copy link
Member Author

Ah good catch thank you @AlexVelezLl. I've updated

@marcellamaki marcellamaki requested a review from AlexVelezLl May 7, 2024 17:49
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marcellamaki!

@marcellamaki marcellamaki merged commit d48617e into learningequality:release-v4 May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants