Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of KResponsiveWindowMixin within KDS #580

Merged

Conversation

rtibbles
Copy link
Member

Description

Updates all internal uses of KResponsiveWindowMixin to use the useKResponsiveWindow composable instead.
Factor out window resizing utilities from the useKResponsiveWindow composable and reuse for all tests using the composable.
Update documentation to recommend the composable over the mixin.

Changelog

  • [#PR no]
    • Description: Remove use of KResponsiveWindowMixin internally
    • Products impact: - none
    • Addresses: -
    • Components: KDateRange, KModal, KPageContainer, KGrid, KFixedGrid, KGridItem, KFixedGridItem
    • Breaking: no
    • Impacts a11y: no
    • Guidance: Updates all components to use the useKResponsiveWindow composable

[#PR no]: PR link

Steps to test

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

});
};

export const testAfterResize = testFunction => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rtibbles, that's helpful

Update documentation to no longer recommend its use.
Update all tests to use window resize test utils.
@rtibbles rtibbles force-pushed the remove_deprecation_warnings branch from e970d51 to 9758591 Compare March 20, 2024 18:11
@rtibbles rtibbles merged commit 3e50547 into learningequality:release-v4 Mar 20, 2024
8 checks passed
@rtibbles rtibbles deleted the remove_deprecation_warnings branch March 20, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants