-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-450: Made KTextTruncator #464
Issue-450: Made KTextTruncator #464
Conversation
@MisRob I tried to find any internal styling that is causing the ellipsis to render a little forward from the last word. But I could not find out what actually causing the issue. Although the KTextTruncator works fine in the |
Thank you @muditchoudhary! We will have a look. Could you please rebase on top of the |
5356f7a
to
533a091
Compare
@MisRob I rebase successfully to the main. Hope it would be good to test. |
Great, thank you @muditchoudhary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @muditchoudhary, code is looking good overall. I left few smaller notes. Also, could you please fix linting check? See package.json for linting commands.
As soon as this is resolved, I will try it out in Kolibri and see if I can observe the issue with the space between ellipsis and text that you mentioned some time ago. In any case, I think this PR won't be a culprit and should be good to go soon.
I'll take care of the changelog check myself before we merge this, so no worries about that one |
533a091
to
ea0135b
Compare
Welcome! I fixed the minor issues you mentioned in the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muditchoudhary Great work and engagement during the review process, thank you.
I tried to find any internal styling that is causing the ellipsis to render a little forward from the last word. But I could not find out what actually causing the issue.
I just tested the place you mentioned in #450 in this regard and everything is okay.
With that, I also confirm I was able to use KTextTruncator
in the latest Kolibri successfully locally so all good!
Leaving only one minor non-blocking note.
…ant variable to check CSR
- Removed the old condition that checks for nuxt client rendering - add this condition because window object is not defined in server rendering - it is present only in client (browser).
ea0135b
to
64d66d0
Compare
@MisRob I added the condition you told me and tested it out, and there is no issue. Also thanks for being helpful in the review. |
Description
This PR creates a KTextTruncator component that will be used to truncate texts and this PR creates a ktexttruncator.vue for the docs of the KTextTruncator component.
Issue addressed
Addresses #450
Before/after screenshots
Steps to test
http://localhost:4000/playground
yarn dev
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
changelog
Reviewer guidance
Comments