-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make KDS contributor friendly #447
Conversation
- Make it friendly for newcomers - Organize existing guidelines into more files - Organize information by focusing on important steps at first, and providing links to more detailed pages when relevant - Add a few new guidelines - Add guidance for contributors to README.md and CONTRIBUTING.md
beb0732
to
6667321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @MisRob. I have not built the pages in my read through to do a manual QA of the docs build, but overall I think this looks great. I've done my best to put myself in the mindset of someone newer to KDS, but I would love input from some of our team members who use KDS a bit less to see if they have any suggestions.
Overall though, I think the clearer sections about contributing, how to get started, the links to the discussion, etc. are a great improvement! Unless someone has a really specific suggestions, I feel good about moving forward with this and then continuing to refine as we get feedback from community contributors.
Thank you, @marcellamaki.
Ah yes, that's a good idea. I am thinking of @ozer550 :) Would you find time to read through the documentation and tried the playground? Doesn't need to be this week. |
Sure! |
@ozer550 Wonderful, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MisRob! This really looks good, and certainly improves the developer experience as a whole. Like Marcella, I will also leave the approval of this PR to folks that have interfaced with KDS the least 🙂
Hi @marcellamaki just noting that you click on the Details link in the highlighted area to view a live preview of the changes made without the need to build the pages yourself. 🙂 |
Wow Today I Learned!! Thank you, Samson 🎉 |
I tried the walkthrough and it seems good to me! Just some errors encountered that might be worth mentioning:
Also I think if we could mention the major version for yarn it could be helpful. The above error got resolved following this stack overflow post guided by @MisRob. Overall it looks good to me! |
Thank you, @ozer550. I will add those improvements before we merge. Any blockers here, anyone? |
No blockers from my perspective! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read every line but overall the changes are fantastic and I really appreciate the dev_docs breakdown of everything for contributors. Thanks so much for all of your effort on this!
All the feedback is addressed and from messages here and on Slack, it looks it's okay to merge. I'll bypass the need for approval as I'd like to reference some of the new sections in the docs easily for one of the contributors soon. |
Description
This is a sibling to Kolibri's PR learningequality/kolibri#11096 and part of larger efforts to make our issues better discoverable, documentation more friendly, and in the case of KDS also easier development process of components for contributors and any newcomers to this repository.
dev_docs
folder and organizes it in to more files while focusing onSteps to test
I think it'd be best to imagine you don't know anything about KDS and read through
Also please try out the new playground page.
Testing checklist
If there are any front-end changes, before/after screenshots are includedCritical and brittle code paths are covered by unit testsThe change has been added to thechangelog
Reviewer guidance
Is the code clean and well-commented?Are there tests for this change?Are all UI components LTR and RTL compliant (if applicable)?