New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix add event type in removeEventListener in useKWindowDimension #400

Merged

rtibbles merged 1 commit into learningequality:develop from pkspyder007:fix-remove-event-listner

Dec 16, 2022

Contributor

pkspyder007 commented Dec 13, 2022

Description

Incorrect arguments to removeEventListener, adds 'resize' as argument on unmount for window.removeEventListener

Issue addressed

Testing

Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical and brittle code paths are covered by unit tests
The change has been added to the changelog

Reviewer guidance

Is the code clean and well-commented?
Are there tests for this change?
Are all UI components LTR and RTL compliant (if applicable)?
Add other things to check for here


          fix add event type in removeEventListener in useKWindowDimension

17230a8

Contributor Author

pkspyder007 commented Dec 16, 2022

@rtibbles any updates on this, its a small change.

rtibbles approved these changes

View reviewed changes

Member

rtibbles left a comment

Correct change and fixes the error.

rtibbles merged commit 043f9de into learningequality:develop

rtibbles mentioned this pull request

Incorrect arguments to removeEventListener #398

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet